fix: include pre-built device_page/dist in resources to fix empty Filament Manager#10832
fix: include pre-built device_page/dist in resources to fix empty Filament Manager#10832BenJule wants to merge 3 commits into
Conversation
BenJule
force-pushed
the
fix/10799-device-page-dist-missing
branch
from
aaf1e66 to
00c37f1
Compare
The upstream build_all.yml only listed 'main' as a push trigger. BenJule/BambuStudio uses 'master' as its default branch, so CI never fired on fork-local pushes. Adding 'master' alongside 'main' makes the full multi-platform build run when master is updated.
…ament Manager
The `resources/web/device_page/dist/` directory was excluded from the
repository by the `**/dist/` gitignore rule. All other web assets in
`resources/web/` are pre-built static files committed directly to git,
but `device_page/dist/` was only generated at CMake build time and never
packaged into the Linux AppImage or macOS DMG releases.
Add a gitignore exception to track `resources/web/device_page/dist/` and
commit the pre-built assets (index.html, assets/index.{css,js}, img/**).
This mirrors how all other embedded web pages in BambuStudio are shipped.
The CMake `device_page_build` target will still rebuild these files on a
full source build; the committed dist serves as the fallback that release
packages rely on.
Closes bambulab#10799
Closes bambulab#10806
BenJule
force-pushed
the
fix/10799-device-page-dist-missing
branch
from
00c37f1 to
09561d7
Compare
|
Same issue found on Linux APPImage |
|
Hi @rochacbruno, Thanks for the feedback. Yeah, that missing The fix is already baked into this PR (Commit #09561d7). I added the pre-built static assets back to the resources directory, which aligns with how the other embedded tabs in Bambu Studio are structured. The PR is just sitting in the queue right now, waiting for review from the BBL team (@MackBambu, @XunZhangBambu, and @walterwongbbl). Once they merge it, the tab will work out of the box in the next AppImage release. Appreciate you bringing it up! |
|
Apologies — this PR was closed by mistake on 2026-06-07, and that was an error on my side, not a deliberate decision to withdraw the change. It happened as an unintended side effect of a branch cleanup in my fork: deleting the head branch automatically closed this PR. The contribution still stands. I have restored the branch and reopened the PR. Sorry for the noise and any confusion this caused. |
2 participants
Problem
The Filament Manager tab shows a blank white page on macOS (issue #10799) and throws a "file not found" error on Linux AppImage (issue #10806).
Root cause:
resources/web/device_page/dist/is excluded from the repository by the**/dist/gitignore rule. All other embedded web pages in BambuStudio (resources/web/fila_manager/,resources/web/device/,resources/web/login/, etc.) are pre-built static assets committed directly to git. Thedevice_page/dist/was the only exception — it was only generated at CMake build time via thedevice_page_buildcustom target, and was never included in the Linux AppImage or macOS DMG release packages.Fix
.gitignoreexception to trackresources/web/device_page/dist/index.html,assets/index.{css,js},img/**)The CMake
device_page_buildtarget still rebuilds these files on a full source build; the committed dist serves as the reliable fallback that release packages depend on — matching the approach used for every other embedded web page.Test plan
resources/web/device_page/dist/index.htmlpresent in packaged AppImageCloses #10799
Closes #10806